Explore progressive enhancement of /all for a11y #15293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhudson
force-pushed
the
15082-a11y-all
branch
from
29b7fe6
to
f0feb95
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15293 +/- ##
==========================================
- Coverage 78.40% 78.40% -0.01%
==========================================
Files 157 157
Lines 8170 8172 +2
==========================================
+ Hits 6406 6407 +1
- Misses 1764 1765 +1 ☔ View full report in Codecov by Sentry. |
|
@reemhamz Would you be willing to look at this locally with your screen reader to see if it helps at all? |
|
Just tested it, and unfortunately it's still disrupting the user flow as it was prior :/ were you able to test it using a screenreader? If so, did it produce different results on your end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
This is an exploration in using progressive enhancement to load only the changed content to improve the a11y issues brought up in the Github issue.
This is an htmx-like approach to rendering only the partial HTML content rather than the full page and using
innerHTMLto write the partial content in place. This seems to work well for me locally but I'm not sure if this solves the a11y issues.Significant changes and points to review
I'm interested if these changes help alleviate this specific issue:
Issue / Bugzilla link
#15082
Testing